-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add read-data-subset to CheckOptions; allow to check given trees #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
aawsome
force-pushed
the
check-more-options
branch
from
September 29, 2024 06:48
06a0cbc
to
7bf0ea4
Compare
simonsan
previously approved these changes
Sep 30, 2024
simonsan
reviewed
Sep 30, 2024
simonsan
approved these changes
Sep 30, 2024
Merged
simonsan
changed the title
feat: Add read-data-subset to CheckOptions; allow to check given trees
feat!: Add read-data-subset to CheckOptions; allow to check given trees
Oct 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
## 🤖 New release * `rustic_backend`: 0.3.0 -> 0.4.0 (⚠️ API breaking changes) * `rustic_core`: 0.4.0 -> 0.5.0 (⚠️ API breaking changes) * `rustic_testing`: 0.2.1 -> 0.2.2 (✓ API compatible changes) ###⚠️ `rustic_backend` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum LocalBackendErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:90 enum RestErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:67 enum BackendAccessErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:10 enum RcloneErrorKind in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/error.rs:43 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/function_missing.ron Failed in: function rustic_backend::choose::extend, previously in file /tmp/.tmpKTBBxT/rustic_backend/src/choose.rs:74 --- failure struct_marked_non_exhaustive: struct marked #[non_exhaustive] --- Description: A public struct has been marked #[non_exhaustive], which will prevent it from being constructed using a struct literal outside of its crate. It previously had no private fields, so a struct literal could be used to construct it outside its crate. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_marked_non_exhaustive.ron Failed in: struct BackendOptions in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/choose.rs:35 struct BackendOptions in /tmp/.tmpiqILEs/rustic_core/crates/backend/src/choose.rs:35 ``` ###⚠️ `rustic_core` breaking changes ``` --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum LimitOption in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/prune.rs:253 --- failure struct_marked_non_exhaustive: struct marked #[non_exhaustive] --- Description: A public struct has been marked #[non_exhaustive], which will prevent it from being constructed using a struct literal outside of its crate. It previously had no private fields, so a struct literal could be used to construct it outside its crate. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_marked_non_exhaustive.ron Failed in: struct RestoreOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:49 struct RepoFileInfos in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:163 struct KeyOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/key.rs:17 struct BlobInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:31 struct FileDirStats in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:74 struct CheckOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/check.rs:125 struct ConfigOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/config.rs:107 struct IndexInfos in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:17 struct PackInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:64 struct TreeStreamerOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/blob/tree.rs:401 struct PruneOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/prune.rs:58 struct RepairSnapshotsOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repair/snapshots.rs:29 struct RestoreStats in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/restore.rs:90 struct RepoFileInfo in /tmp/.tmpiqILEs/rustic_core/crates/core/src/commands/repoinfo.rs:173 struct LocalSourceFilterOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/backend/ignore.rs:71 struct LocalSourceSaveOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/backend/ignore.rs:51 struct RepositoryOptions in /tmp/.tmpiqILEs/rustic_core/crates/core/src/repository.rs:88 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.4.0](rustic_backend-v0.3.0...rustic_backend-v0.4.0) - 2024-10-02 ### Fixed - Add #[non_exhaustive] to pub structs which may be extended in future ([#293](#293)) - *(backend)* [**breaking**] Use correct merge stratgy for repository options ([#291](#291)) ### Other - *(deps)* update dependencies ([#292](#292)) - *(deps)* use conflate instead of merge crate ([#284](#284)) </blockquote> ## `rustic_core` <blockquote> ## [0.5.0](rustic_core-v0.4.0...rustic_core-v0.5.0) - 2024-10-02 ### Added - Add read-data-subset to CheckOptions; allow to check given trees ([#262](#262)) - Add Repository method to update snapshot collections ([#260](#260)) ### Fixed - Add #[non_exhaustive] to pub structs which may be extended in future ([#293](#293)) - Don't query the default cache directory when a custom one is set ([#285](#285)) ### Other - *(deps)* update dependencies ([#292](#292)) - *(deps)* use conflate instead of merge crate ([#284](#284)) </blockquote> ## `rustic_testing` <blockquote> ## [0.2.2](rustic_testing-v0.2.1...rustic_testing-v0.2.2) - 2024-10-02 ### Other - *(deps)* update dependencies ([#292](#292)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Fixes a regression introduced by #262: Check without `--read-data` throws lots of error because we changed the access to the index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Repository::check_with_trees
which allows to do tree and data check only for the given trees.Moreover,
CheckOptions
now have theread_data_subset
option which allows to read only parts of the pack files.Also warming up of packfiles in case of hot/cold respository has been added.
closes rustic-rs/rustic#251